Could I see a page where this doesn’t work? I’m curious about the markup.

hello,

the page isn’t online yet – it is a WP 3.8.1 without any plugins but yours and i want to open links from a std. gallery, I don’t know if i can copy html code in here, lets see …

…

in the theme i created some custom post types and the gallery is on one of them, but just for testing it didn’t work with a gallery in a usual post or page neither – the css in the header and the js in the footer get loaded on both pages though …

thanks,
M

well, seems that copying html-code didn’t work,

here it is …
http://pastebin.com/d82D3vub

alright, i found the error … seems like your plugin doesn’t load jquery on its own. a simple

wp_enqueue_script(“jquery”);
in the functions.php of the theme did the trick.
nevertheless i think you should include it in future releases of the plugin.

well, thanks for the plugin – works like a charm now 🙂

M

Oh. Right. I didn’t really account for someone not having any other plugin than this. Thanks for the testing. I commited the changes (r3). It should be working now without any other plugin 🙂

I’d say it’s a specific issue with Imagelightbox.js and that jQuery version.

It is WordPress v3.9 and I don’t think that I should tamper with the WordPress code, in the wp-includes/js/jquery/jquery.js

There is no problem with the latest browsers Chrome, Firefox and iPhone, but only with IE9.

I just tested it now on Firefox and it seems to be working fine.

Could you also try on Osvaldas’ website and see if his works fine? Maybe you have a Firefox addon that interferes with it? (I have a “clean” firefox profile without addons)

Oh ok then probably it’s just my Firefox. I have tried on Osvaldas’ website as well and same problem when im on firefox… I’ll have a look on it and see how it goes.
Thanks! 🙂

Weird… comments form stripped the forward slash
In above “After plugin” text… plugin puts forwards slash in front of
/ data-imagelightbox=”f”>

( forward slash before data-imagelightbox=”f” )

Not sure if the comments form will remove the forward slash again in this addendum reply.

It’s OK… finally figured out how to make it 100% HTML5 validate on my site. Now, no errors.
Modified these 2 lines in wp-imagelightbox.php :
$pattern = “//i”;
$replacement = ‘‘;

Hey, sorry for not seeing your messages earlier, but I’m glad you figured out how to make it work.

Unfortunately I can’t replicate your usage case. I don’t see a forward-slash appended in my output. I could only think that maybe another plugin on your blog is adding some weird markup which my regex doesn’t work with.

I’ll have to investigate when I have time.

You could simply just re-run the init function after you’re adding elements to the DOM:

  var d = 'a[data-imagelightbox="f"]';
  var v = jQuery(d).imageLightbox({
    onStart: function() {
      a(v, d);
      n();
      i(v)
    },
    onEnd: function() {
      l();
      r();
      u();
      s();
      t()
    },
    onLoadStart: function() {
      u();
      e()
    },
    onLoadEnd: function() {
      f(d);
      t();
      o()
    }
  })

Hey! Znuff I tried that, but that would just create another instance. I finally figured it out. You can reset all the instances of the lightbox by unbinding the ‘click’ event with jQuery’s .off(). Then, you can just re-initialize the lightbox:

var selector = ‘a[data-imagelightbox=”f”]’;
$(document).off(‘click’,selector);
var instance = $(selector).imageLightbox({ … });

Hope this will help others too! 🙂
Cheers!

This helped me greatly, thanks!

Hi.

That version (well, this version that is running right here) is not yet published on the wordpress.org repository. I didn’t exactly have time to polish it more.

I will try to make some time, soon.